[9.5] Backport bbq_flat yaml refresh fixes#154996
Open
mayya-sharipova wants to merge 1 commit into
Open
Conversation
Backports two test-only visibility fixes to 9.5: - elastic#154272 add index refresh to bbq yaml tests - elastic#154688 add index refresh after forced merge The 9.5 setup for search.vectors/42_knn_search_bbq_flat never refreshed after indexing/forcemerge, so the knn search could run against a pre-refresh view missing the last-indexed doc, intermittently returning 2 hits instead of 3. Also unmutes the corresponding test (elastic#154705).
mayya-sharipova
added
backport
:Search Relevance/Vectors
mayya-sharipova
added
>test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports two test-only visibility fixes to
9.5:Why
The
9.5setup forsearch.vectors/42_knn_search_bbq_flat("Test knn search") indexed three docs and force-merged but never refreshed before searching. This resulted in intermittently returning 2 hits instead of 3 and failing:Both refresh fixes already exist on
mainbut were never backported to9.5/9.4; this brings9.5in line withmain.Closes #154705